Fix sectionless files silently dropping all settings#6
Open
FIFER-Mods wants to merge 1 commit into
Open
Conversation
A config with top-level settings but no [section] header parsed to an empty Configuration. The default section holding those settings is only added when a [section] header is read, so with no header it was never added. Add it after the parse loop instead.
FIFER-Mods
force-pushed
the
fix/sectionless-keys-dropped
branch
from
41ce070 to
b89746c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A config with top-level settings but no
[section]header parses to an emptyConfiguration:The default section that holds those settings is only added to the config when a
[section]header is read. With no header it's never added, so the settings are lost. This adds it after the parse loop.The writer already omits the header for the default section, so these files round-trip unchanged.