Upgrade Guava library to version 32.0.0-jre in cdap#16149
Merged
sahusanket merged 1 commit intoJul 23, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a dependency on Guava to cdap-data-fabric and introduces a workaround class TxMetricsCollector to satisfy the Tephra TransactionManager. The review feedback highlights that using reflection to invoke start/stop and startAsync/stopAsync on the delegate service is unnecessary and problematic. It introduces performance overhead from caught exceptions and risks IllegalAccessException on newer Java versions. The reviewer suggests directly calling delegate.startAsync() and delegate.stopAsync() instead.
shruthi713
approved these changes
Jul 17, 2026
Simplify TxMetricsCollector start/stop methods using direct calls to delegate instead of reflection
AbhishekKumar9984
force-pushed
the
metrics-cloudsufi-guava-upgrade
branch
from
July 20, 2026 10:46
3ddecca to
8689976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the Guava dependency version in pom.xml to 32.0.0-jre.
Ensured compatibility with the upgraded Guava version.