Skip to content

Poll interval #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claud-io merged 5 commits into from
Dec 2, 2024
Merged

Poll interval #198

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ed1178d
initial commit
Siddhantshukla814 Oct 30, 2024
5c6733a
const file
Siddhantshukla814 Nov 4, 2024
1a5ca45
lower limit variable
Siddhantshukla814 Nov 4, 2024
ae6971e
version bump
Siddhantshukla814 Nov 5, 2024
e7cf63d
export fix
Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/consts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export const DEFAULT_POLL_VALUE = 60;
export const POLL_LOWER_LIMIT = 20;
6 changes: 4 additions & 2 deletions lib/webpagetest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ var http = require("http"),
server = require("./server"),
mapping = require("./mapping");

const { DEFAULT_POLL_VALUE, POLL_LOWER_LIMIT} = require("./consts");

var reSpace = /\s/,
reConnectivity =
/^(?:Cable|DSL|3GSlow|3G|3GFast|4G|LTE|Edge|2G|Dial|FIOS|Native|custom)$/,
Expand Down Expand Up @@ -474,7 +476,7 @@ function runTest(what, options, callback) {

// poll results
if (options.pollResults && !options.dryRun) {
options.pollResults = parseInt(options.pollResults * 1000, 10) || 5000;
options.pollResults = Math.max(POLL_LOWER_LIMIT, options.pollResults || DEFAULT_POLL_VALUE) * 1000;

return api.call(
this,
Expand Down Expand Up @@ -537,7 +539,7 @@ function runTest(what, options, callback) {
function runTestAndWait(what, options, callback) {
delete options.pollResults;

options = Object.assign(options, { pollResults: 13 });
options = Object.assign(options, { pollResults: DEFAULT_POLL_VALUE });

new Promise((resolve) => {
let test = runTest.bind(this, what, options, callback);
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "webpagetest",
"version": "0.7.5",
"version": "0.7.6",
"description": "WebPageTest API wrapper for NodeJS",
"author": "WebPageTest <github@WebPageTest.com> (http://github.com/WebPageTest)",
"homepage": "http://github.com/WebPageTest/webpagetest-api",
Expand Down