fix(sources): handle streaming request errors

[gcomneno]

Summary

Wrap request exceptions raised while streaming file source downloads into NetworkRequestError, so file source failures surface as source-facing errors instead of raw requests exceptions.

Testing

• pytest -q tests/unit/sources/test_base.py -rs

Issue

Closes #1396

[bepri]

Thanks, @gcomneno. Checked this out locally and it seems good! Undoing your change in base.py breaks the unit test as I'd expect.

Would you mind adding a change log entry for this as well? You can assume it'll be part of the next patch release and put a placeholder like "Unreleased" for the date and we'll just update it once we know more about the next date/version.

[gcomneno]

Thanks, Imani — done. I added a changelog entry under Unreleased and pushed the update.

[gcomneno]

I checked the current CI failures.

The QA/lint / files failure appears unrelated to this PR: the docs linkcheck is failing on an external packages.ubuntu.com URL with a 500 response in dotnet_v2_plugin.rst.

The test-other-plugins failure also looks transient/external from the current logs: the first failing job hits an interrupted Launchpad download and raises NetworkRequestError, after which the remaining matrix jobs are cancelled.

Could someone please rerun the failed jobs when convenient?

[gcomneno]

I checked the current CI failures.

The QA/lint / files failure appears unrelated to this PR: docs linkcheck is failing on an external packages.ubuntu.com URL in dotnet_v2_plugin.rst with a 500 response.

The test-other-plugins failures also look external/transient from the logs: the first failing job hits an interrupted Launchpad download while pulling a tar source, after which the rest of the matrix gets cancelled.

Could someone please rerun the failed jobs when convenient?

[gcomneno]

Hi! Just gently following up on this one.

This PR is approved, and the current remaining blockers look CI-related rather than code review feedback:

• Security scan / OSV-scanner
• test-common / Slow tests (noble, ppc64el, edge, 3.12)
• test-java-plugins / Slow tests (ubuntu-24.04-arm, 3.12)

Could someone please rerun the failed jobs when convenient? Happy to adjust anything if I missed a code-related failure.

[lengau]

Thanks!

[lengau]

@gcomneno I've merged the latest and approved test runs — we have a test-flaky job now which should contain those flaky tests so we can hopefully limit the flakiness issue :-)

[Copilot]

Pull request overview

This PR improves file-source download error handling by ensuring exceptions raised during streaming downloads surface as source-facing NetworkRequestError rather than raw requests exceptions.

Changes:

• Move the streaming download (url_utils.download_request(...)) into the request exception-handling block so streaming failures are wrapped consistently.
• Add a unit test covering a streaming ChunkedEncodingError during URL pulls.
• Document the fix in the unreleased changelog.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
craft_parts/sources/base.py	Wraps streaming download exceptions into NetworkRequestError by moving the streaming call inside the existing try/except.
tests/unit/sources/test_base.py	Adds a unit test to assert streaming request exceptions are raised as NetworkRequestError.
docs/reference/changelog.rst	Adds an unreleased changelog entry documenting the bug fix.