Skip to content

Tweak when we include the AR transaction callback rescuing - #709

Closed
apalmblad wants to merge 2 commits into
bugsnag:masterfrom
apalmblad:stop-grabbing-exceptions
Closed

apalmblad wants to merge 2 commits into
bugsnag:masterfrom
apalmblad:stop-grabbing-exceptions

Conversation

@apalmblad

@apalmblad apalmblad commented Nov 15, 2021

Copy link
Copy Markdown
Contributor

Goal

Bugsnag notifies when we see an exception in a transaction (or rollback) callback. This is unnecessary as Rails now raises exceptions out of transaction callbacks. This Bugsnag behaviour means that certain errors are always sent to bugsnag instead of potentially handled elsewhere.

Bugsnag behaviour can be seen here: https://github.com/apalmblad/bugsnag-ruby/blob/master/lib/bugsnag/integrations/rails/active_record_rescue.rb#L14

Rails has stopped swallowing exceptions in these callbacks, making in configurable in Rails 4, and then the default behaviour in Rails 5.
Rails allowing exceptions to be raised
Rails 5 removing configuration for not raising callback exceptions

Design

To minimize changes needed, I consider the rails version and the various configuration values and conditionally include the file.

Changeset

The rails integration behaviour was changed, and we stop including it.

Testing

I've added a spec to check whether or not its included.

Comment on lines +73 to +78
if Rails::VESION::MAJOR == 4
if ActiveRecord::Base.errors_in_transactional_callbacks == :raise
require "bugsnag/integrations/rails/active_record_rescue"
include Bugsnag::Rails::ActiveRecordRescue
end
elsif Rails::VESION::MAJOR < 4

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if Rails::VESION::MAJOR == 4
if ActiveRecord::Base.errors_in_transactional_callbacks == :raise
require "bugsnag/integrations/rails/active_record_rescue"
include Bugsnag::Rails::ActiveRecordRescue
end
elsif Rails::VESION::MAJOR < 4
if Rails::VERSION::MAJOR == 4
if ActiveRecord::Base.errors_in_transactional_callbacks == :raise
require "bugsnag/integrations/rails/active_record_rescue"
include Bugsnag::Rails::ActiveRecordRescue
end
elsif Rails::VERSION::MAJOR < 4

@imjoehaines

Copy link
Copy Markdown
Contributor

Thanks for the PR, @apalmblad!

I'll merge this in #717, where I've added tests to our Rails test apps to get better coverage of this behaviour

@apalmblad

Copy link
Copy Markdown
Contributor Author

Thanks for putting this in.

@imjoehaines imjoehaines mentioned this pull request Jan 20, 2022
@xljones

xljones commented Jan 21, 2022

Copy link
Copy Markdown

Released in https://github.com/bugsnag/bugsnag-ruby/releases/tag/v6.24.2 🎉 , thanks for the contribution!

@xljones xljones added bug Confirmed bug released This feature/bug fix has been released labels Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Confirmed bug released This feature/bug fix has been released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants