Resque fork - #347
Merged
Merged
Resque fork#347
Conversation
this should allow jobs that run inline to still have the app_type set correctly as before_first_fork is always called regardless of forking per worker or not. When forking is used for the jobs then the configuration will only be set in the forked worker
martin308
force-pushed
the
resque-fork
branch
from
February 10, 2017 17:26
e7ca8b6 to
091704a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion for moving forward with #335.
Check if we are forking the worker and if so only perform the configuration after the fork has occurred. If not then retain the old behavior.