Safer setProcessStateSummary in ExitInfo plugin#2197
Merged
Conversation
…a worker thread and swallow any exceptions
lemnik
force-pushed
the
PLAT-14342/safe-setProcessStateSummary
branch
from
49f2b36 to
9260f09
Compare
Collaborator
Android notifier sizes
Generated by 🚫 Danger |
lemnik
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Avoid timeouts and crashes stemming from rate limiting or slow IPC calls when using
setProcessStateSummaryin the ExitInfo Plugin.Changes
The
SessionCallbacknow uses theBackgroundTaskServiceto enqueue the call tosetProcessStateSummaryand further swallows any exceptions raised by the call.Testing
Relied on existing tests.