Use typed data API#37
Open
nobu wants to merge 3 commits into
Open
Conversation
Allocate the parser with Data_Make_Struct so Ruby owns the memory as soon as the object is created. This avoids leaking the malloc buffer if Data_Wrap_Struct raises while allocating the Ruby object.
Use TypedData_Make_Struct and TypedData_Get_Struct when available so the parser wrapper does not depend on the old Data_* accessors removed by newer Ruby.
Use const char pointers for data callbacks so their signatures match llhttp_data_cb and the assignments no longer need function pointer casts.
|
@bryanp sorry for the ping, but any chance you could merge and release this? Testing ruby prereleases is pretty hard right now because of this PR. |
Owner
|
@byroot yes, will get to it this week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.