Skip to content

Update nan - #39

Closed
Qard wants to merge 1 commit into
brianc:masterfrom
Qard:patch-1
Closed

Update nan#39
Qard wants to merge 1 commit into
brianc:masterfrom
Qard:patch-1

Conversation

@Qard

@Qard Qard commented Apr 12, 2016

Copy link
Copy Markdown

Node v6 is incoming, and nan 2.2.x is needed to support it.

@Qard

Qard commented Apr 26, 2016

Copy link
Copy Markdown
Author

Node v6 is out now, and libpq currently does not build on it.

@brianc

brianc commented Apr 26, 2016

Copy link
Copy Markdown
Owner

Hey @Qard - I really appreciate you putting this together. One small request: can you add v6 to the .travis.yml file? That way we can be sure this fixes for node v6 and also make sure we never break compatibility in the future. After that I'll happily merge!

@Qard Stephen Belanger
Update nan
a5592bb 
Node v6 is incoming, and nan 2.2.x is needed to support it.
@Qard

Qard commented Apr 27, 2016

Copy link
Copy Markdown
Author

Looks like it's having issues due to nodejs/node#6228, actually. I think it'll have to wait for another version of nan.

@ruimarinho

ruimarinho commented Apr 27, 2016

Copy link
Copy Markdown

The fix has been merged (nodejs/nan@00dacf0) and published as nan@2.3.0.

ruimarinho
ruimarinho reviewed Apr 27, 2016
View reviewed changes
Comment thread package.json
"license": "MIT",
"dependencies": {
"nan": "^2.0.4",
"nan": "^2.2.1",

@ruimarinho ruimarinho Apr 27, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^2.3.0?

@brianc brianc mentioned this pull request Apr 27, 2016
Merged
@Qard

Qard commented Apr 29, 2016

Copy link
Copy Markdown
Author

Closing, as this appears to be fixed by #41. Thanks!

@Qard Qard closed this Apr 29, 2016
@brianc

brianc commented Apr 29, 2016

Copy link
Copy Markdown
Owner

thank YOU

On Fri, Apr 29, 2016 at 4:10 PM, Stephen Belanger notifications@github.com
wrote:

Closed #39 #39.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#39 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Qard @brianc @ruimarinho