Add battery stats#800
Merged
Merged
Conversation
Member
|
looks ok to me, naming probably could be better since ancillary is the name of preset(buffer) but its ok |
Member
|
let me know when you test it and will include it in the next release |
Member
|
any updates? |
Contributor
Author
|
Sorry for delay, getting ready for talk at a conference! I think I will update the naming convention and then it should be ready to merge. The stats are working reliably on our side. |
Rename ancillary_channel to avoid conflict with existing preset buffer
Contributor
Author
|
@Andrey1994 this should be ready to review. My colleague @calebkuitenbrouwer was able to address the naming issue, let us know if his changes look good to you as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tracking for the following battery statistics: