fix(#44) complex values#86
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: ca08fb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ulken
force-pushed
the
fix-44_complex_values
branch
from
048f8b4 to
c308518
Compare
ulken
force-pushed
the
fix-44_complex_values
branch
from
3b2139c to
ca08fb6
Compare
ulken
commented
Feb 26, 2023
| export interface SelectOptions<Options extends Option<Value>[], Value extends Primitive> { | ||
|
|
||
| type Option<Value> = Value extends Primitive | ||
| ? { value: Value; label?: string; hint?: string } |
Collaborator
Author
There was a problem hiding this comment.
Suppose we could extract aliases for these, if it would make it easier to decipher violations?
type PrimitiveOption<Value extends Primitive> = { value: Value; label?: string; hint?: string>
type ComplexOption<Value> = { value: Value; label: string; hint?: string>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Select prompts (incl. multi + group-multi):
Fixes #44 (for realz).
Note:
selectKeyis not supported since it requiresvalueto bestring.