Skip to content

fix(language): accept numeric schema aliases before preprocessing#202

Merged
kgruszka merged 1 commit into
developfrom
fix/schema-numeric-alias-node
Jun 6, 2026
Merged

fix(language): accept numeric schema aliases before preprocessing#202
kgruszka merged 1 commit into
developfrom
fix/schema-numeric-alias-node

Conversation

@kgruszka

@kgruszka kgruszka commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@kgruszka
kgruszka merged commit 303f2de into develop Jun 6, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 028a04611d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +443 to +444
new BigDecimalNumber(value);
return true;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reject doubles that overflow binary64

For explicit Double schema nodes with a string value outside the finite JS double range, such as value: "1e309", this branch now accepts the schema because BigDecimalNumber can parse arbitrary-size decimals. After preprocessing changes type: Double to the core blueId, BlueNode.getValue() still rounds via parseFloat and tries to construct a decimal from Infinity, so schema verification or consumers that read the value can throw later instead of rejecting the malformed schema during deserialization as before.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant