Skip to content

fix: show private channels in channel browser when user is a member#311

Merged
tellaho merged 1 commit into
block:mainfrom
damienrj:fix/channel-browser-show-private-channels
Apr 13, 2026
Merged

fix: show private channels in channel browser when user is a member#311
tellaho merged 1 commit into
block:mainfrom
damienrj:fix/channel-browser-show-private-channels

Conversation

@damienrj

Copy link
Copy Markdown
Contributor

Summary

  • The channel browser filter excluded all non-archived private channels, even when the user was already a member
  • The database layer (get_accessible_channels) correctly returns private channels the user belongs to, but the frontend browsableChannels memo in ChannelBrowserDialog.tsx only allowed visibility === "open" for non-archived channels
  • Added || channel.isMember to the filter so joined private channels appear in browse/search results

The browsable channels filter only allowed non-archived channels with
visibility "open", excluding private channels even when the user was
already a member. Add an isMember check so joined private channels
appear in search results.
@damienrj damienrj requested a review from wesbillman as a code owner April 13, 2026 22:32
@tellaho tellaho merged commit 364010d into block:main Apr 13, 2026
10 checks passed
tellaho added a commit that referenced this pull request Apr 14, 2026
* origin/main:
  feat(desktop): deterministic nested thread panels (#308)
  fix: show private channels in channel browser when user is a member (#311)

# Conflicts:
#	desktop/src/features/channels/ui/ChannelPane.tsx
tlongwell-block added a commit that referenced this pull request Apr 14, 2026
* origin/main:
  feat(desktop): deterministic nested thread panels (#308)
  fix: show private channels in channel browser when user is a member (#311)
  Replace inline channel creation with dialog (#312)
  chore: improve chat message layout to left-aligned design (#309)
  Add edit dialog for managed agents with relay profile sync (#277)
  fix(ci): build relay with optimized profile to fix flaky e2e tests (#307)
  Update actions/checkout action to v6 (#305)
  Update dependency @tanstack/react-query to v5.98.0 (#304)
  Update dependency @playwright/test to v1.59.1 (#303)
  Update react monorepo to v19.2.5 (#302)
  feat(mobile): scaffold Flutter app with Riverpod & Catppuccin theme (#306)
  Update dependency @tanstack/react-router to v1.168.13 (#301)
  feat: Markdown-based persona packs (crate + ACP + desktop) (#297)
  feat(desktop): improve Agents page UX (#298)

# Conflicts:
#	desktop/scripts/check-file-sizes.mjs
#	desktop/src-tauri/Cargo.lock
#	desktop/src-tauri/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants