Skip to content

Fix flaky desktop smoke tests#294

Merged
wesbillman merged 1 commit into
mainfrom
devin/fix-flaky-e2e
Apr 10, 2026
Merged

Fix flaky desktop smoke tests#294
wesbillman merged 1 commit into
mainfrom
devin/fix-flaky-e2e

Conversation

@wesbillman

Copy link
Copy Markdown
Collaborator

Summary

  • add missing mocked window commands so the desktop app no longer crashes into the generic error screen in mock-mode smoke runs
  • wait for the mock live subscription before asserting typing indicators, removing the channel typing race without going back to blind sleeps
  • keep search smoke coverage stable while still proving the Cmd/Ctrl+K shortcut path explicitly

Validation

  • pnpm test:e2e:smoke (83/83)
  • pre-commit and pre-push hooks (pnpm check, pnpm build, Rust fmt, Rust clippy)

Review

  • ran Codex CLI as an adversarial reviewer against the diff
  • addressed the two findings it surfaced: typing subscription readiness and preserving shortcut coverage

@wesbillman wesbillman force-pushed the devin/fix-flaky-e2e branch from f6d2dce to fb58c8c Compare April 10, 2026 23:21
@wesbillman wesbillman merged commit 3ef19f2 into main Apr 10, 2026
9 checks passed
@wesbillman wesbillman deleted the devin/fix-flaky-e2e branch April 10, 2026 23:31
tlongwell-block added a commit that referenced this pull request Apr 11, 2026
…ona-migration

* origin/main:
  feat(desktop): add Pulse social notes surface (#296)
  Fix flaky desktop smoke tests (#294)
  Add agent lifecycle controls to channel members sidebar (#291)
  Update nest_agents.md tagging info (#292)
  feat: add Sprout nest — persistent agent workspace at ~/.sprout (#290)
  Fix auth and SSRF vulns (#261)
  Add per-agent MCP toolset configuration to agent setup (#279)
  feat(desktop): team & persona import/edit flows (#288)
  Remove menu item subtitles and fix persona card overflow (#289)
  feat: Phase 1 video upload support (Blossom-compliant-ish) (#285)
  Add inline subtitles to menu items and field descriptions (#276)
  Improve ephemeral channel affordances and hide archived sidebar rows (#286)
  Fix @mention search to use word-boundary prefix matching (#278)
  Allow bot owners to remove their agents from any channel (#284)
  [codex] Polish agent selectors and settings layout (#283)

# Conflicts:
#	desktop/scripts/check-file-sizes.mjs
tellaho added a commit that referenced this pull request Apr 14, 2026
* origin/main:
  Replace inline channel creation with dialog (#312)
  chore: improve chat message layout to left-aligned design (#309)
  Add edit dialog for managed agents with relay profile sync (#277)
  fix(ci): build relay with optimized profile to fix flaky e2e tests (#307)
  Update actions/checkout action to v6 (#305)
  Update dependency @tanstack/react-query to v5.98.0 (#304)
  Update dependency @playwright/test to v1.59.1 (#303)
  Update react monorepo to v19.2.5 (#302)
  feat(mobile): scaffold Flutter app with Riverpod & Catppuccin theme (#306)
  Update dependency @tanstack/react-router to v1.168.13 (#301)
  feat: Markdown-based persona packs (crate + ACP + desktop) (#297)
  feat(desktop): improve Agents page UX (#298)
  feat(desktop): add Pulse social notes surface (#296)
  Fix flaky desktop smoke tests (#294)
  Add agent lifecycle controls to channel members sidebar (#291)

# Conflicts:
#	desktop/pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant