fix(desktop): render autolinked message links as chips#1241
Merged
Conversation
Render CommonMark autolinks such as `<buzz://message?...>` through the same message-link pill component as bare pasted message links, while preserving explicitly labeled message links. Centralize the anchor-rendering decision in the message-link helper so the bare-link plugin path and Markdown anchor path share the same parsing and URL-shape assumptions. Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
wesbillman
force-pushed
the
pinky/message-link-autolink
branch
from
1a5f87e to
c0189e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buzz://message?...URLs through the message-link chip UIMessageLinkPillfor plugin-generated and autolink-generated message links[here](buzz://message?...)as normal labeled linksTest plan
cd desktop && ../bin/pnpm typecheckcd desktop && ../bin/pnpm checkcd desktop && ../bin/pnpm test