Skip to content

Polish desktop navigation chrome#1238

Merged
wesbillman merged 5 commits into
mainfrom
kennylopez-navigation-bar-staging-20260624
Jun 24, 2026
Merged

Polish desktop navigation chrome#1238
wesbillman merged 5 commits into
mainfrom
kennylopez-navigation-bar-staging-20260624

Conversation

@klopez4212

@klopez4212 klopez4212 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add an in-flow sidebar-colored navigation bar for the sidebar, back, and forward controls.
  • Round and faintly stroke the main content panel so it tucks cleanly under the new chrome.
  • Normalize header/search spacing around 36px content rows and restore list-view top padding.

Snapshots

Channel chrome

Channel chrome

Agents panel

Agents panel

Validation

  • pnpm --dir desktop exec biome check ...
  • pnpm --dir desktop run --if-present typecheck
  • pnpm --dir desktop run --if-present check:px-text
  • git diff --check
  • just desktop-screenshot for channel chrome and agents panel snapshots
  • code-checks: reviewed changed lines; fixed the only discovered padding consistency issue

@klopez4212 klopez4212 marked this pull request as ready for review June 24, 2026 12:30

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4a6986040c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/messages/ui/MessageThreadPanel.tsx Outdated
Comment thread desktop/src/features/profile/ui/UserProfilePanel.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a121cce89

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/app/AppShell.tsx
Comment thread desktop/src/features/workflows/ui/WorkflowsView.tsx
Comment thread desktop/src/features/channels/ui/AgentSessionThreadPanel.tsx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d10177f4f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/tests/e2e/sidebar-more-unread-overlap.spec.ts
@wesbillman wesbillman merged commit 0925464 into main Jun 24, 2026
29 checks passed
@wesbillman wesbillman deleted the kennylopez-navigation-bar-staging-20260624 branch June 24, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants