fix(desktop): keep channel header search/add icons always visible#1144
Merged
Conversation
The "Channels" header browse (search) and create (+) buttons in SectionHeaderActions carried SECTION_ACTION_VISIBILITY_CLASS, fading them to opacity-0 unless the section group was hovered or focused. Users had no way to discover them at rest. #856 originally made these always visible; a later sidebar-polish pass reintroduced the fade. Drop the visibility class from both buttons so they render at the shared SECTION_ICON_BUTTON_CLASS resting opacity (50%) and still brighten on hover/focus, matching every other always-present sidebar icon. The contextual mark-all-read button keeps its hover-reveal behavior. Co-authored-by: npub1qyvc0c5kl4gqv2fd97fsk46tu378sqgy35vc83rvgfwne90sel7s0ed67d <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@sprout-oss.stage.blox.sqprod.co> Signed-off-by: npub1qyvc0c5kl4gqv2fd97fsk46tu378sqgy35vc83rvgfwne90sel7s0ed67d <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@sprout-oss.stage.blox.sqprod.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Channels" header search (🔍) and add (+) icons in the left channel bar fade to
opacity-0unless the section is hovered or focused. At rest they're invisible, so users can't discover how to browse or create channels. Reported by Tyler in #buzz-bugs.Cause
SectionHeaderActions(desktop/src/features/sidebar/ui/CustomChannelSection.tsx) appliesSECTION_ACTION_VISIBILITY_CLASS(opacity-0 … group-hover/focus-within:opacity-100) to the browse and create buttons. #856 originally made these always visible; a later sidebar-polish pass reintroduced the fade — so this is a regression.Fix
Drop
SECTION_ACTION_VISIBILITY_CLASSfrom those two buttons. They now render at the sharedSECTION_ICON_BUTTON_CLASSresting opacity (50%) and still brighten on hover/focus, matching every other always-present sidebar icon. The contextual mark-all-read (✓✓) button keeps its hover-reveal behavior — it only appears on unread and wasn't part of the report.2 insertions, 8 deletions, one file.
Verification
biome check✓ ·tsc --noEmit✓