fix: give agent-observer sub a replay-capable limit#1100
Merged
Conversation
The observer live subscription used limit:0, which the relay's historical path truncates to LIMIT 0 (NIP-01: limit 0 = no rows). On reconnect, the client replays each live REQ with a since window to backfill the gap, but limit:0 truncated that replay to zero — so a turn_started fired during a network drop never re-delivered and the active-agents badge never appeared. Mirror subscribeToChannelLive's limit:1000; since:now still suppresses launch history, only reconnect replay changes. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
The fix's correctness rests on two properties: limit:1000 (reconnect replay can recover missed frames) and since:now (launch history stays suppressed). The guard asserted only the limit, so a future edit dropping since:now would reintroduce up-to-1000 rows of launch backfill while the test stayed green. Pin both halves of the contract. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
tlongwell-block
pushed a commit
that referenced
this pull request
Jun 18, 2026
…te-response * origin/main: (194 commits) Fold agent core memory into the session system prompt (#1112) feat(cli): add patches and issues commands for NIP-34 git collaboration (#1073) fix(desktop): stop random timeline message loss + page reconnect replay (#1105) Update README.md fix(desktop): keep thread replies from scrolling channel (#1109) fix(buzz-acp): accept siblings under allowlist author gate (#1108) feat(deploy): add production Helm chart for Buzz (#990) fix(desktop): keep MembersSidebar input usable while an add is in flight (#1106) chore(release): release version 0.3.25 (#1102) fix(desktop): stop dimming deferred message lists (#1104) Smooth channel loading: single-surface timeline state machine (#1099) feat: surface base + persona system prompts in observer feed (#1103) ci: move reminder e2e to a dedicated backend-integration job (#1098) fix: give agent-observer sub a replay-capable limit (#1100) fix: make managed-agent spawn and teardown portable to Windows (#1097) fix(desktop): constrain message timeline width with min-w-0 (#1092) feat(desktop): reminders notifications, snooze, overlay, and inbox view mode (#1093) feat(prompt): add memory hygiene and hoist universal engineering discipline to base prompt (#1085) fix(desktop): correct thread-unread badge flicker, stale clear, phantom count, mention gate, and nested count (#1080) Fix mention chip alignment (#1094) ... # Conflicts: # crates/buzz-cli/src/commands/workflows.rs
tlongwell-block
pushed a commit
that referenced
this pull request
Jun 18, 2026
…te-response * origin/main: (194 commits) Fold agent core memory into the session system prompt (#1112) feat(cli): add patches and issues commands for NIP-34 git collaboration (#1073) fix(desktop): stop random timeline message loss + page reconnect replay (#1105) Update README.md fix(desktop): keep thread replies from scrolling channel (#1109) fix(buzz-acp): accept siblings under allowlist author gate (#1108) feat(deploy): add production Helm chart for Buzz (#990) fix(desktop): keep MembersSidebar input usable while an add is in flight (#1106) chore(release): release version 0.3.25 (#1102) fix(desktop): stop dimming deferred message lists (#1104) Smooth channel loading: single-surface timeline state machine (#1099) feat: surface base + persona system prompts in observer feed (#1103) ci: move reminder e2e to a dedicated backend-integration job (#1098) fix: give agent-observer sub a replay-capable limit (#1100) fix: make managed-agent spawn and teardown portable to Windows (#1097) fix(desktop): constrain message timeline width with min-w-0 (#1092) feat(desktop): reminders notifications, snooze, overlay, and inbox view mode (#1093) feat(prompt): add memory hygiene and hoist universal engineering discipline to base prompt (#1085) fix(desktop): correct thread-unread badge flicker, stale clear, phantom count, mention gate, and nested count (#1080) Fix mention chip alignment (#1094) ... Co-authored-by: Tyler Longwell <tlongwell@squareup.com> Signed-off-by: Tyler Longwell <tlongwell@squareup.com> # Conflicts: # crates/buzz-cli/src/commands/workflows.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under WARP VPN churn, an agent's active-timer badge sometimes never appeared for a turn that was genuinely in progress: the agent kept working and the turn eventually finished, but the badge was missing the whole time.
The active-agents badge is purely event-driven —
activeAgentTurnsStorederives every turn fromturn_started/turn_completed/turn_livenessobserver frames. The relay client already does gap-recovery on reconnect: it replays each liveREQwith asincewindow to backfill events missed during a drop. The agent-observer subscription opted out of that recovery by passinglimit: 0, which the relay's historical path correctly truncates to zero rows (NIP-01:limit 0means "no historical results"). So on reconnect the observerREQmatched the gap window and was then truncated to nothing — aturn_startedthat fired mid-drop never re-delivered, and the badge never showed.The cause is one-sided: the observer sub is the only reconnect-dependent subscription that opted out of replay. The fix mirrors the proven
subscribeToChannelLivepattern — a replay-capablelimit: 1000(which clamps cleanly at the DB'smax_limit.unwrap_or(1000)cap), withsince: nowunchanged so launch-time history stays suppressed and only the reconnect replay window changes. Re-delivered frames are idempotent against the store's(timestamp, seq)watermark, so there is no double-count.A regression-guard test asserts
subscribeToAgentObserverFramesrequestslimit: 1000; store idempotency under replay is already covered byactiveAgentTurnsStore.test.mjs.