Improve image lightbox controls#1084
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f457ae73df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-image-lightbox-overlay
branch
from
f457ae7 to
a8e062a
Compare
|
🤖 Screenshot for the updated image lightbox overlay.
|
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
Thorough review focused on usefulness vs. over-engineering.
Overall: Genuinely useful change and mostly not over-engineered. The source-rect "grow from where it sits" animation + glassy download/zoom bar is a clear UX upgrade over the old fixed-box Radix dialog, and it deliberately mirrors the established VideoPlayer.tsx overlay pattern (same createPortal, double-requestAnimationFrame enter, same backdrop-blur-xl backdrop-saturate-150 bg-black/35 glass bar). Accessibility is handled (role=dialog, aria-modal, sr-only description, focus, Escape, body scroll lock).
A few places where complexity could be trimmed — inline comments below. The only hard ask is the duplicated reduced-motion hook; the rest are judgment calls.
Not blockers: tsc --noEmit is blocked by pre-existing animatedAvatarCapture.ts / @mediapipe errors on main — confirmed unrelated to this PR.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7743e2f637
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3cf8198958
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99f9866ace
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: deed14c88c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81af89671c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
Summary
Checks
git diff --cached --check../node_modules/.bin/biome check --config-path=./biome.json src/shared/ui/markdown.tsx src/shared/styles/globals.css./node_modules/.bin/tsc --noEmit(blocked by existinganimatedAvatarCapture.ts/@mediapipe/tasks-visionerrors in this checkout)