Skip to content

doc: use arch agnostic clang path in fuzzing doc (macOS) - #27056

Merged
maflcko merged 1 commit into
bitcoin:masterfrom
fanquake:macos_fuzzing_doc_arch_agnostic
Feb 8, 2023
Merged

doc: use arch agnostic clang path in fuzzing doc (macOS)#27056
maflcko merged 1 commit into
bitcoin:masterfrom
fanquake:macos_fuzzing_doc_arch_agnostic

Conversation

@fanquake

@fanquake fanquake commented Feb 7, 2023

Copy link
Copy Markdown
Member

The current path will only work for clang installed via brew on x86_64 macOS.

@DrahtBot

DrahtBot commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto
Stale ACK jonatack

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Docs label Feb 7, 2023

@jonatack jonatack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK, as it looks like the path changed from /usr/local/opt/ for x86_64 to /opt/homebrew/opt/ for ARM64.

Comment thread doc/fuzzing.md Outdated
@jonatack

jonatack commented Feb 7, 2023

Copy link
Copy Markdown
Member

ACK 8b16f7b7c2fa7407ec4023f4581ea9dd1758eec0

Comment thread doc/fuzzing.md Outdated
@fanquake
fanquake force-pushed the macos_fuzzing_doc_arch_agnostic branch from 8b16f7b to b49e19c Compare February 8, 2023 09:45

@hebasto hebasto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b49e19c, similar to 7028365.

I've also verified our code base for other similar cases:

$ git grep -e "/usr/local/opt" | wc -l
0

@maflcko
maflcko merged commit de1d189 into bitcoin:master Feb 8, 2023
@fanquake
fanquake deleted the macos_fuzzing_doc_arch_agnostic branch February 8, 2023 11:52
@bitcoin bitcoin locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants