[pull] main from QwenLM:main - #533
Merged
Merged
Conversation
…t related docs (#10479) * test(core): pin tools.eager Object.prototype-key tolerance and correct related docs Item 1 of #10400 (a tools.eager entry named after an Object.prototype key crashing PermissionManager.initialize) was already fixed before #10098 merged: resolveToolName only reads own properties of the alias table and the crashing unknown-entry loop was removed. Pin that contract with regression tests so a reintroduction fails CI: - initialize() tolerates constructor/toString/valueOf/... eager entries - resolveToolName returns Object.prototype-keyed names unchanged - config.test.ts: add the third LS x tools.eager cell (enabled and covered by the list -> registered eagerly) Also correct the doc inaccuracies tracked in the issue: - settings.md: permissions.deny blocks MCP tool calls at runtime but does not remove them from the registry (tools.disabled / the per-server excludeTools filter does) - ToolSearch-absent caveat (5 copies): note the resumed-session history re-reveal and tools.visible carve-outs - sdk-typescript docs + README: note the tools.eager exempt families Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> * test(core): cover visible permission-deferred tools Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> --------- Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Copy buttons flip to a check mark and schedule a bare setTimeout(() => setCopied(false)) to reset it. When a test file's environment is torn down within that window the callback throws ReferenceError: window is not defined out of react-dom's state dispatch, and since the unit suites fail on unhandled errors an all-green run exits 1 — main's own Test (ubuntu) hits this through AssistantMessage.test.tsx. A new useCopiedFlash hook owns the transient flag: flash() sets it and schedules the reset, a re-flash restarts the window instead of letting the older timer cut the newer feedback short, and unmount clears the pending timer. The six call sites with the bare pattern (assistant, system and timestamp messages, both Markdown code-block buttons, the Git log dialog) adopt it; SessionOverviewPanel's SessionIdCell already carried the cleanup. Two tests pin the cleanup via vi.getTimerCount() after unmount and one pins the restarted window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )