feat(flags): add missing flags and reword metadata - #11248
Conversation
🦋 Changeset detectedLatest commit: 3ef60f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Organic activityNo automation signals detected in the analyzed events. This is an automated analysis by AgentScan |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (10)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughExpands environment-variable documentation with supported values, defaults, usage guidance, and shell examples. Documents Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/bright-otters-write.md:
- Line 5: Update the changeset description to use past-tense verbs consistently,
changing the opening “Expands” and the “reworded” phrasing to describe the
completed metadata and explanation changes.
In `@crates/biome_flags/src/lib.rs`:
- Around line 161-183: Add a focused Rust test for BiomeEnv::ENV_VARIABLES that
verifies BIOME_BINARY, BIOME_LOG_FILE, and RUST_BACKTRACE are registered with
non-empty descriptions; if no existing registry test covers all entries, assert
the complete registry contract as well.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 74fa5c8a-c45c-4f65-b2ca-45380b211dd5
⛔ Files ignored due to path filters (10)
crates/biome_cli/tests/snapshots/main_commands_rage/rage_ok.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_rage/with_configuration.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_rage/with_custom_config_path.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_rage/with_formatter_configuration.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_rage/with_jsonc_configuration.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_rage/with_linter_configuration.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_rage/with_linter_domain_configuration.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_rage/with_malformed_configuration.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_rage/with_missing_custom_config_path.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_rage/with_no_configuration.snapis excluded by!**/*.snapand included by**
📒 Files selected for processing (2)
.changeset/bright-otters-write.mdcrates/biome_flags/src/lib.rs
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Thank you. I left some comments
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
The language looks good to me, Yan, with some nice consistency!
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
This PR is good to be merged alongside biomejs/website#4420, feel free to merge when it makes sense @ematipico (not super used to the release flow here) |
3 participants
Summary
This PR is a sibling docs PR that rewords environment variable flags to be more descriptive and readable. I've also added information for
BIOME_LOG_FILE,BIOME_BINARYandRUST_BACKTRACE, which I guess now means those will also show up when someone usesbiome rage.This means the core repository file becomes the source of truth for this information, instead of a weird mix between generating from core repo + appended information for
BIOME_BINARYandRUST_BACKTRACEin the website repo.Test Plan
N/A
Docs