Switch to JFileChooser on Mac with VAqua

[sampottinger]

Due to the regression in FileDialog causing command c / command v to no longer work within FileDialog on Mac, having OS X use JFileChooser for the editor. This is keeping with the precedent set in processing/processing#1035. In response, switch to VAqua for a not terrible file mac-feel chooser (which also gives us dark mode!).

Resolves #77.
Resolves #89.

Blocked on #74.

[sampottinger]

I put this up because the precendent from processing/processing#1035 seems clear. That said, I'm on fence about this. I feel like there's too much benefit for using FileDialog even if copy / paste doesn't work. That said, the fact that you are unknowingly modifying the sketch code while attempting to copy / paste into the dialog is pretty bad.

[sampottinger]

Ugh. I looked into this including a series of abandoned 3rd party libs. It doesn't look like there's an easy alternative. :(

[sampottinger]

Yay great news! Vaqua might work.

[sampottinger]

Yay Vaqua works! This is good to go!

[sampottinger]

Sorry continuous integration on my side caught a missing jar.

[sampottinger]

Should be fixed now.

[sampottinger]

Hey there! There's a few PRs outstanding (with inter-dependencies) and the build on master has been broken on Mac for some time. So, I have an integration branch over at https://github.com/sampottinger/processing4 master. That branch includes this PR. This allows one to use Processing 4 again on a Mac along with all of the recent bug fixes. For your convenience, I have made builds available at https://www.datadrivenempathy.com/processing.

[clankill3r]

Using VAqua will bump the minimum requirement for processing to OSX 10.10, I don't know if this is a problem, but something to be aware of.

[sampottinger]

Good call @clankill3r. I am adding in a version guard. Everything is API compatible so, if Vaqua isn't available because OS X is too old, it will just revert to the regular OS X swing behavior (with the bad JFileChooser).

[sampottinger]

Thanks so much @benfry! Just made some updates below. Thanks!

Min mac version
Resolved with Info.plist.

Download Jar
I switched this out so that it downloads from vaqua's site. However, I re-encountered an issue I had forgotten about. There's extraneous output that comes from vaqua on some macs when opening the save dialog as shown:

The message is not useful and it's not an error. I rebuilt the jar without that message but it does mean it's a custom jar. LMK how you want to proceed.

Preferences
I resolved all the questions except for how to represent this in the preferences. LMK how you want to proceed. I currently have a draft proposal in here with the following defaults:

# Default to the native (AWT) file selector where possible
chooser.files.native = true
chooser.files.native.macosx = false # except on mac where it's broken

Plus the addition of editor.allow_vaqua which defaults to true.

[sampottinger]

This is available on an integration branch at https://github.com/sampottinger/processing4 (master) for testing in the context of other open PRs with a community build at https://www.datadrivenempathy.com/processing.

[benfry]

Is the custom build thing solved by doing checkout/patch/build as part of the build process? Can that be done with a couple lines in build.xml or is it more complex than that?

Opting to merge, though a little nervous about no new releases since February 2019 (i.e. no Catalina release, and this debug message still embedded.) Didn't see a link to a source repo to see if there's any development version or sign of commits.

[clankill3r]

I appreciate the hard work but I think this is a case of over engineering.
While command+c command+v now works it comes at the cost of:

• having no search field
• having no recent locations
• no Favourites or Locations (so a USB stick has to be accessed by going to Mac/Volumes for example)
• no "Show items as" or "Group items by"
• thick font rendering

[benfry]

This has since been reverted, and alpha 4 is not using VAqua. Please use a new issue if there's a problem.