chore(scenarios): promote 002-clean-pr-zero-findings to active#38
Merged
Conversation
First successful walk completed 2026-06-03 against a README-only diff of bborbe/coding master at sha 3b6adf2. All 7 Expected checkboxes satisfied: exit 0 — code-review ran to completion findings_count = 0 — runner reported 0 findings across 27 YAMLs Must Fix / Should Fix / Nice to Have section bodies all 'None.' no 'dropped finding' log lines (citation validator had nothing to drop because no findings were generated) run completes under 30s wall clock (target was under 5min) Side-finding (not on scenario contract): rules/go/nosec-requires-reason.yml uses pattern-regex (ast-grep 0.43 only supports 'regex'). Separate fix PR will follow.
![ben-s-pull-request-reviewer[bot]](https://avatars.githubusercontent.com/u/1193284?s=60&v=4){kind=small}
bborbe
added a commit
that referenced
this pull request
Jun 3, 2026
…bot review Bot correctly flagged that scenarios/004 was not referenced in README.md or llms.txt; broader audit found scenarios/001-003 were also never indexed (oversight in PRs #37, #38, #40). Closing the gap retroactively for all 4 active scenarios. README.md: new 'Acceptance Scenarios' section above Contributing with a 4-row table linking each scenario file + one-line 'Validates...' description. llms.txt: parallel section at the bottom so AI agents relying on llms.txt for discovery can find the scenarios alongside guides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First successful walk of scenario 002 completed 2026-06-03 against a README-only diff of bborbe/coding master at sha `3b6adf2`. Per the scenario-writing guide status lifecycle, the scenario moves `draft → active` after first successful run.
Walk result
All 7 Expected checkboxes satisfied:
Side-finding (separate fix)
`rules/go/nosec-requires-reason.yml` uses `pattern-regex` (ast-grep 0.43 supports `regex` only). The bash loop in scenario 002's walk surfaced this — the rule is broken on master. Separate fix PR will follow; scenario 002's assertion set does not depend on this YAML running cleanly.
Test plan