feat(licensing): bootstrap 4 rule blocks in go-licensing-guide

[bborbe]

Summary

Bootstraps `docs/go-licensing-guide.md` — 4 MUST sections restructured into canonical `### RULE` blocks. Mirrors PRs #2-5, #8, #10.

`rules/index.json`: 42 → 46 entries.

Rules added

id	level	enforcement
`go-licensing/license-file-required`	MUST	judgment (file-existence)
`go-licensing/readme-license-section-required`	MUST	judgment (markdown structure)
`go-licensing/source-file-header-required`	MUST	`addlicense -check` via `make precommit` (canonical tool)
`go-licensing/copyright-year-discipline`	MUST	judgment (diff-scope reasoning)

Notes

• Public-vs-private distinction preserved — all 4 rules scoped to `github.com/*` public projects; private/internal (`bitbucket.seibert.tools` etc.) exempt.
• `source-file-header-required` delegates mechanical enforcement to `addlicense -check` rather than a custom ast-grep YAML — `addlicense` is the canonical tool already wired into `make precommit` for projects that opt in.
• `copyright-year-discipline` is theoretically partially mechanical (future-year detection could be ast-grep) but the "no bulk-update for trivial changes" trigger needs PR-scope reasoning, so the rule stays judgment-only for now.

PR #13's check-index caught the walker drift

First `make precommit` failed with the new `check-index` target catching the unregen'd `rules/index.json`. Ran `make build-index`, re-ran precommit clean. Drift guard working as designed — the gap that turned PR #9 into a two-PR walker-regen catch-up is now closed at the precommit boundary.

Pre-emptive checks

• `grep -nEi "personal/|/users/bborbe|~/documents/obsidian"` → clean
• Trading-term grep → clean
• All 4 rule IDs unique (no collision with existing 42 entries)
• `license-assistant` agent exists at `agents/license-assistant.md` — owner field resolves

Test plan

• `make precommit` clean (including new `check-index`)
• `make build-index` ran; 4 new entries indexed with MUST level + license-assistant owner
• Bot review

[ben-s-pull-request-reviewer]

PR Review Complete

Summary

Reviewed the feat(licensing): bootstrap 4 rule blocks in go-licensing-guide PR which adds 4 new RULE blocks to docs/go-licensing-guide.md and corresponding entries to rules/index.json. The rules (go-licensing/license-file-required, go-licensing/readme-license-section-required, go-licensing/source-file-header-required, go-licensing/copyright-year-discipline) are well-defined with proper enforcement mechanisms and alignment between doc anchors and index entries. The source-file-header-required rule correctly leverages the existing addlicense -check tool already wired into make precommit.

Must Fix (Critical)

None identified.

Should Fix (Important)

• Index insertion at position 188: The 4 new entries in rules/index.json were inserted mid-file at line 188 rather than appended at the end. This creates unnecessary merge conflict surface if other PRs are editing the index simultaneously. Future bootstrap PRs should append new entries at the end of the array.

Nice to Have (Optional)

None.

Plan Concerns Addressed

1. Index position — Valid concern. Not blocking but noted above.
2. Mid-section RULE placement — Not an issue. RULE blocks are correctly placed within their logical sections per the guide's structure.
3. Judgment-only enforcement for copyright-year-discipline — Correct design. Bulk-update detection requires PR-scope reasoning beyond mechanical ast-grep patterns.

---

{
  "verdict": "approve",
  "summary": "The PR correctly bootstraps 4 licensing RULE blocks into go-licensing-guide.md with aligned index.json entries. All rule definitions are sound, enforcement mechanisms are appropriate (tooled for addlicense, judgment for others), and doc-anchor alignment is correct. One minor merge-hygiene concern: new index entries were inserted mid-file rather than appended at end.",
  "comments": [
    {
      "file": "rules/index.json",
      "line": 191,
      "severity": "major",
      "message": "Should Fix: New licensing rule entries inserted at position 188 rather than appended at array end. This creates unnecessary merge conflict risk with concurrent PRs editing the index. Append new entries at the end of the array instead."
    }
  ],
  "concerns_addressed": [
    "correctness: rules/index.json - 4 new entries added with correct structure and alignment to doc anchors",
    "correctness: docs/go-licensing-guide.md - RULE blocks placed in appropriate logical sections",
    "correctness: copyright-year-discipline rule correctly uses judgment enforcement (ast-grep cannot detect bulk-update intent)"
  ]
}