Fix label override provided by custom container_image rules - #2233
Merged
Conversation
_image_config was retrieving labels from ctx instead of the labels arg.
hamsterstorm
marked this pull request as ready for review
March 15, 2023 22:54
hamsterstorm
requested review from
gravypod,
linzhp,
pcj,
smukherj1 and
uhthomas
as code owners
March 15, 2023 22:54
linzhp
approved these changes
Mar 16, 2023
faximan
added a commit
to googlecloudrobotics/core
that referenced
this pull request
Apr 17, 2023
Pulls in bazelbuild/rules_docker#2233 which is expected by downstream repos. Looks like rules_docker haven't had a labelled release in a while, hence the commit reference. This corresponds to http://cl/517244821.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_image_config was retrieving labels from ctx instead of the
labels arg.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information