Set MaxIdleConnsPerHost for pushes - #2132
Merged
Merged
Conversation
This should reduce "use of closed network connection" errors due to too many idle connections. Because we only expect to reach a couple hosts during pushes anyway, this should be safe. Currently, the value defaults to 2. This change sets it to half the total IdleConnsPerHost, which defaults to 100. New value is 100 / 2 = 50.
jonjohnsonjr
marked this pull request as ready for review
July 22, 2022 20:06
jonjohnsonjr
requested review from
gravypod,
linzhp,
pcj,
smukherj1 and
uhthomas
as code owners
July 22, 2022 20:06
St0rmingBr4in
pushed a commit
to St0rmingBr4in/rules_docker
that referenced
this pull request
Oct 17, 2022
This should reduce "use of closed network connection" errors due to too many idle connections. Because we only expect to reach a couple hosts during pushes anyway, this should be safe. Currently, the value defaults to 2. This change sets it to half the total IdleConnsPerHost, which defaults to 100. New value is 100 / 2 = 50.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should reduce "use of closed network connection" errors due to too
many idle connections. Because we only expect to reach a couple hosts
during pushes anyway, this should be safe.
Currently, the value defaults to 2. This change sets it to half the
total IdleConnsPerHost, which defaults to 100.
New value is 100 / 2 = 50.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Only 2 idle connections are permitted per host, which can lead to issues when pushing many layers.
Issue Number: #1989
What is the new behavior?
Allow 50 idle connections per host.
Does this PR introduce a breaking change?
Other information