Update rules_pkg to the latest release. - #2125
Merged
Merged
Conversation
aiuto
requested review from
gravypod,
linzhp,
pcj,
smukherj1 and
uhthomas
as code owners
July 7, 2022 14:33
Collaborator
|
Looks good, though we may be using an old version of rules_pkg by the looks of it. |
Author
|
Fixed. |
Author
|
Friendly ping |
linzhp
approved these changes
Jul 20, 2022
St0rmingBr4in
pushed a commit
to St0rmingBr4in/rules_docker
that referenced
this pull request
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
pkg_tar is being referenced at a legacy location (@rules_pkg//:pkg.bzl) which will go away in a future release of rules_pkg. This PR updates rules_pkg to the latest release and fixes the references to be to the correct location (@rules_pkg//pkg:tar.bzl) which will remain correct indefinitely.
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information