Add a release workflow that with the correct crafted tag of a release… - #2086
Merged
Conversation
… will add the binaries built from the repo
ianoc
requested review from
gravypod,
linzhp,
pcj,
smukherj1 and
uhthomas
as code owners
May 12, 2022 03:04
12 tasks
Contributor
Author
linzhp
approved these changes
May 26, 2022
St0rmingBr4in
pushed a commit
to St0rmingBr4in/rules_docker
that referenced
this pull request
Oct 17, 2022
… will add the binaries built from the repo (bazelbuild#2086)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… will add the binaries built from the repo
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Right now some external system i believe produces the binaries used in releases
What is the new behavior?
A maintainer can make a release at any time starting with
docker-tools-, e.g.docker-tools-v1and the github actions will populate that release with binaries hosted by github of the tools used. Github sorts releases, so they won't appear at the top. And so maintainers can as part of a mainline release first do a tools release, get the new binaries and do a main release. Also anyone can fork this repo and reproduce the same experience.Does this PR introduce a breaking change?
Other information