Add .bazelversion - #2066
Merged
Merged
Conversation
laurynaslubys
requested review from
alexeagle,
gravypod,
pcj and
smukherj1
as code owners
April 23, 2022 11:16
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
laurynaslubys
force-pushed
the
add_bazelversion
branch
from
April 23, 2022 11:22
dfb1c98 to
e6c9e24
Compare
linzhp
reviewed
May 5, 2022
linzhp
left a comment
linzhp
left a comment
Collaborator
There was a problem hiding this comment.
Have you tried other 4.x versions like 4.2.1?
Contributor
Author
|
IIRC, it works, but CI is currently using 4.0.0, so it would be nice to keep this in sync. |
linzhp
approved these changes
May 9, 2022
St0rmingBr4in
pushed a commit
to St0rmingBr4in/rules_docker
that referenced
this pull request
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The repository is built using whatever version of bazel I have in my path. Unfortunately, it doesn't seem to work with bazel 5.1.0.
Issue Number: N/A
What is the new behavior?
Add a .bazelversion so that bazelisk knows that the repo is supposed to be built using 4.0.0, as that is the version that is used in CI.
Does this PR introduce a breaking change?
Other information