Skip to content

Run script allows empty docker_args #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linzhp merged 1 commit into from
Apr 19, 2022
Merged

Run script allows empty docker_args #2053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion container/incremental_load.sh.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,17 @@ if [[ "%{run}" == "True" ]]; then
# We can clean up before we exec docker, since the exit handler will no longer run.
cleanup

# Bash treats empty arrays as unset variables for the purposes of `set -u`, so we only
# conditionally add these arrays to our args.
args=(%{run_statement})
if [[ ${#docker_args[@]} -gt 0 ]]; then
args+=("${docker_args[@]}")
fi
args+=("%{run_tag}")
if [[ ${#container_args[@]} -gt 0 ]]; then
args+=("${container_args[@]}")
fi

# This generated and injected by docker_*.
eval exec %{run_statement} "${docker_args[@]}" "%{run_tag}" "${container_args[@]:-}"
eval exec "${args[@]}"
fi