Fix pusher flags for --config and --tarball - #1998
Merged
Merged
Conversation
jonjohnsonjr
requested review from
alexeagle,
gravypod,
pcj and
smukherj1
as code owners
January 12, 2022 21:36
jonjohnsonjr
force-pushed
the
pusher-fix
branch
from
January 12, 2022 21:41
4997102 to
7eb1dc0
Compare
This was done for the digester in bazelbuild#1721 but not the pusher. This change makes them consistent again.
jonjohnsonjr
force-pushed
the
pusher-fix
branch
from
January 12, 2022 21:43
7eb1dc0 to
079889f
Compare
alexeagle
approved these changes
Jan 13, 2022
alexeagle
left a comment
alexeagle
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Good to see you here 🤩
Contributor
Author
|
Thanks! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
pusherrequired specifying--configeven when--tarballwas specified.What is the new behavior?
pusherworks without--configif--tarballis specified.Does this PR introduce a breaking change?
Other information
This was done for the digester in #1721 but not the pusher. This change makes them consistent again.
The flag descriptions got confused in #1118 when these binaries were made backward compatible with the previous versions.