Do not use constraints from bazel_tools - #1956
Merged
Merged
Conversation
limdor
requested review from
alexeagle,
gravypod,
pcj and
smukherj1
as code owners
November 8, 2021 20:36
Collaborator
|
Hello @limdor. This change looks good but I'd like to know: is there a reason this needs to be done? I'm assuming this blocks some migration or deprecation in bazel_tools or something. I just want to know what to tell future people if they ask about this change. |
gravypod
approved these changes
Nov 8, 2021
Collaborator
|
Ah, I just saw the attached bug! Thanks for putting this together. |
Contributor
Author
|
@gravypod it seems that I'm the first one seeing this but this is needed to be able to compile with Bazel 5.0. It would be good if a release could be created soon that contains this changes. Without it rules_docker cannot be used in Bazel 5.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1953
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?