Experimental: migrate cloudbuild to buildkite - #1784
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
|
Note: turning on Need to resolve this (add a secret) to use remote execution in this context. |
|
List of failing tests on github action:
Planning to exclude these |
|
Issue migrating |
|
OK, pausing work on this for now. Here's where it stands: I migrated a bunch of stuff off cloudbuild to buildkite without too much difficulty. The remaining ones have special requirements and/or I don't know what they are supposed to do:
Also, at this intermediate stage the presubmit is only testing on ubuntu. Need to restore the macos coverage. |
|
@smukherj1 @gravypod do you want to sync on this sometime later in the week? |
|
cc @alexeagle |
|
Looks like we should discuss at next maintainer meeting? Do you want a review on this now? |
|
Resolving some of those unknowns I enumerated above best during a meeting. Any other PR comments certainly welcome. |
…ls/dependency_update/validators/semantics:latest
|
The ubuntu keyserver gpg key sha256 changed. Here is the value I am currently seeing: http_file(
name = "launchpad_openjdk_gpg",
sha256 = "e9a596d0c194a562be9fd2c2a0994d7885505a1145fed0fbd5ae4c11d56220a0",
urls = ["https://keyserver.ubuntu.com/pks/lookup?op=get&fingerprint=on&search=0xEB9B1D8886F44E2A"],
) |
|
Subsumed by #1859 |
Remove travis and cloudbuild, update buildkite.
I started this PR intending to replace cloudbuild with github actions. However, as I got into it I realized there was already some overlap/duplication between the cloudbuild coverage and buildkite coverage. Given we want to migrate everything to BK eventually anyway, I skipped the intermediate step.