Skip to content

Run compiler info collection in the execution root - #8406

Merged
LeFrosch merged 1 commit into
bazelbuild:masterfrom
LeFrosch:pull/cf61bafe88eb5d735b0ddc60ea102db96c3c8317
Jul 21, 2026
Merged

Run compiler info collection in the execution root#8406
LeFrosch merged 1 commit into
bazelbuild:masterfrom
LeFrosch:pull/cf61bafe88eb5d735b0ddc60ea102db96c3c8317

Conversation

@LeFrosch

Copy link
Copy Markdown
Collaborator

When the compiler has to resolve paths into the external directory, it has to be executed from the execution root.

When the compiler has to resolve paths into the external directory, it has to be executed from the execution root.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors BlazeCWorkspace.java to pass BlazeProjectData instead of WorkspaceRoot to the commit and collectCompilerSettingsInParallel methods. This allows the configuration to use the execution root path from BlazeProjectData rather than the workspace root directory. Additionally, unused imports were removed and minor formatting improvements were made. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@LeFrosch
LeFrosch marked this pull request as ready for review July 16, 2026 15:38
@LeFrosch
LeFrosch requested review from mai93 and ujohnny as code owners July 16, 2026 15:38
@github-actions github-actions Bot added product: CLion CLion plugin awaiting-review Awaiting review from Bazel team on PRs labels Jul 16, 2026
@LeFrosch
LeFrosch merged commit f053d14 into bazelbuild:master Jul 21, 2026
8 checks passed
@LeFrosch
LeFrosch deleted the pull/cf61bafe88eb5d735b0ddc60ea102db96c3c8317 branch July 21, 2026 13:24
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in Bazel IntelliJ Plugin Jul 21, 2026
@github-actions github-actions Bot removed the awaiting-review Awaiting review from Bazel team on PRs label Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product: CLion CLion plugin

Projects

Development

Successfully merging this pull request may close these issues.

2 participants