Skip to content

chore(cleanup): remove SyncStrategy and simplify sync logic - #8405

Merged
LeFrosch merged 2 commits into
bazelbuild:masterfrom
LeFrosch:pull/d67f98b970b66cf406fc7891c20fb9e8b7901625
Jul 21, 2026
Merged

chore(cleanup): remove SyncStrategy and simplify sync logic#8405
LeFrosch merged 2 commits into
bazelbuild:masterfrom
LeFrosch:pull/d67f98b970b66cf406fc7891c20fb9e8b7901625

Conversation

@LeFrosch

Copy link
Copy Markdown
Collaborator

Eliminated the SyncStrategy enum and updated relevant code paths to default to serial execution, since it was hardcoded to serial for the BazelBuildSystem anyway.

Eliminated the `SyncStrategy` enum and updated relevant code paths to default to serial execution, since it was hardcoded to serial for the BazelBuildSystem anyway.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the SyncStrategy configuration and parallel sync capabilities from the build system, simplifying target sharding and defaulting sync builds to run serially. The reviewer suggests further cleanups to eliminate redundant ternary operators and unused fields resulting from these hardcoded defaults, specifically by directly using singleThreadedExecutor in SyncPhaseCoordinator and defaultInvoker in BuildPhaseSyncTask.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread base/src/com/google/idea/blaze/base/sync/SyncPhaseCoordinator.java
Comment thread base/src/com/google/idea/blaze/base/sync/BuildPhaseSyncTask.java Outdated
@LeFrosch
LeFrosch marked this pull request as ready for review July 16, 2026 15:38
@LeFrosch
LeFrosch requested review from mai93 and ujohnny as code owners July 16, 2026 15:38
@github-actions github-actions Bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Jul 16, 2026
@LeFrosch
LeFrosch merged commit 2807948 into bazelbuild:master Jul 21, 2026
6 checks passed
@LeFrosch
LeFrosch deleted the pull/d67f98b970b66cf406fc7891c20fb9e8b7901625 branch July 21, 2026 13:25
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in Bazel IntelliJ Plugin Jul 21, 2026
@github-actions github-actions Bot removed the awaiting-review Awaiting review from Bazel team on PRs label Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin

Projects

Development

Successfully merging this pull request may close these issues.

2 participants