Skip to content

clion: fix configuration selector widget - #8329

Merged
LeFrosch merged 1 commit into
bazelbuild:masterfrom
ujohnny:enovozhilov/cnfe
May 19, 2026
Merged

clion: fix configuration selector widget#8329
LeFrosch merged 1 commit into
bazelbuild:masterfrom
ujohnny:enovozhilov/cnfe

Conversation

@ujohnny

@ujohnny ujohnny commented May 13, 2026

Copy link
Copy Markdown
Collaborator

remove letsplot usages to avoid classloading issue

@ujohnny
ujohnny requested review from LeFrosch and mai93 as code owners May 13, 2026 09:03
@github-actions github-actions Bot added product: CLion CLion plugin awaiting-review Awaiting review from Bazel team on PRs labels May 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes an external dependency and refactors the logic for generating the configuration map in BazelResolveConfigurationToolbar.kt. A review comment suggests using buildMap instead of the current mapNotNull and toMap chain to improve efficiency by avoiding intermediate Pair allocations and providing a more idiomatic Kotlin implementation.

Comment thread clwb/src/com/google/idea/blaze/clwb/radler/BazelResolveConfigurationToolbar.kt Outdated
remove letsplot usages to avoid classloading issue
@ujohnny
ujohnny force-pushed the enovozhilov/cnfe branch from bff145f to f1cbee9 Compare May 13, 2026 15:33
@LeFrosch
LeFrosch merged commit c2087cf into bazelbuild:master May 19, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in Bazel IntelliJ Plugin May 19, 2026
@github-actions github-actions Bot removed the awaiting-review Awaiting review from Bazel team on PRs label May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product: CLion CLion plugin

Projects

Development

Successfully merging this pull request may close these issues.

2 participants