Skip to content

Update dependency protobuf to v34.1 - #8260

Closed
renovate-bot wants to merge 1 commit into
bazelbuild:masterfrom
renovate-bot:renovate/protobuf-monorepo
Closed

Update dependency protobuf to v34.1#8260
renovate-bot wants to merge 1 commit into
bazelbuild:masterfrom
renovate-bot:renovate/protobuf-monorepo

Conversation

@renovate-bot

@renovate-bot renovate-bot commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
protobuf bazel_dep minor 34.0.bcr.134.1

Release Notes

protocolbuffers/protobuf (protobuf)

v34.1: Protocol Buffers v34.1

Announcements

  • Protobuf News may include additional announcements or pre-announcements for upcoming changes.

Bazel

  • Moved protocopt flag out of the cc dir, since it is not a c++-specific flag. (3db9fd1)
  • Add support for bazel 9.x (#​26201) (763c5da)

C++

  • Updated CMake dependencies. (5583485)
  • Add cc_proto_library for MessageSet in //src/google/protobuf/bridge (523a6a4)
  • Add support for bazel 9.x (#​26201) (763c5da)

Java

  • Avoid toBigIntegerExact in JsonFormat to avoid degenerate parse behavior in the face of large exponents. (ab3d7f0)

Python

Other

  • Fixed release_prep.sh script mkdir command to follow INTEGRITY_FILE location. (e700d7d)
  • Second try at fixing the release_prep.sh file path! (#​26097) (f5ccaf3)

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on upgrading the protobuf dependency to its latest minor version, 34.1. This update propagates changes throughout the Bazel module system, leading to a comprehensive refresh of the MODULE.bazel.lock file. The lock file now includes updated hashes and versions for various other modules, ensuring consistency and incorporating the latest compatible versions across the build system.

Highlights

  • Protobuf Dependency Update: The protobuf dependency has been updated from version 34.0.bcr.1 to 34.1 in the MODULE.bazel file, reflecting a minor version upgrade.
  • Bazel Lock File Updates: The MODULE.bazel.lock file has been extensively updated to reflect the new protobuf version and also includes updates for several other Bazel modules such as apple_support, aspect_bazel_lib, bazel_features, jsoncpp, rules_android, rules_java, and rules_kotlin. Additionally, new Bazel extensions for system_python, apksig, and com_android_dex have been added to the lock file.
  • Test Project Protobuf Update: The protobuf dependency in the clwb/tests/projects/protobuf/MODULE.bazel test project has also been updated to 34.1 to align with the main project's dependency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the protobuf dependency to version 34.1. The changes in MODULE.bazel and the test project's MODULE.bazel are straightforward. However, the MODULE.bazel.lock file contains updates for other direct dependencies like the clion SDK and PythonCore plugins, which are not reflected in the MODULE.bazel diff for this PR. This inconsistency between the module definition and the lock file is a critical issue that could lead to unpredictable builds. The lock file must accurately reflect the intended dependencies defined in MODULE.bazel.

Comment thread MODULE.bazel.lock Outdated
Comment on lines +345 to +347
"sha256": "4e1a694e99709e6f698aab31c4f9d0531dd05bfa763644e5ee8d163447fe2505",
"product": "clion",
"version": "261.22158.47-EAP-SNAPSHOT"
"version": "261.22158.190-EAP-SNAPSHOT"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The lock file is being updated for the clion SDK, but there is no corresponding change in MODULE.bazel within this pull request's diffs. This creates an inconsistency between the module definition and the lock file, which can lead to unpredictable builds. If this update is intentional, the change should also be present in MODULE.bazel.

Comment thread MODULE.bazel.lock Outdated
Comment on lines +362 to +371
"sha256": "2d537031f4e5e2db5c9ccfa7703781518a829b293c0133a8690f6700092dd9f2",
"url": "https://plugins.jetbrains.com/maven/com/jetbrains/plugins/PythonCore/253.32098.37/PythonCore-253.32098.37.zip"
}
},
"python_2026_1": {
"repoRuleId": "@@bazel_tools//tools/build_defs/repo:http.bzl%http_archive",
"attributes": {
"build_file": "@@//intellij_platform_sdk:BUILD.python",
"sha256": "5feec57a08bddd5aa7fdc72af5b977b850de980c25f6f6e4d6b59a3e0c18edf5",
"url": "https://plugins.jetbrains.com/maven/com/jetbrains/plugins/PythonCore/261.22158.46/PythonCore-261.22158.46.zip"
"sha256": "7443dfbb718efcf00d7bc790e58af2c8d9fdc5a911ce44c80764a38915226f62",
"url": "https://plugins.jetbrains.com/maven/com/jetbrains/plugins/PythonCore/261.22158.182/PythonCore-261.22158.182.zip"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The PythonCore plugin versions are being updated in the lock file without a corresponding change in MODULE.bazel in this PR's diffs. This discrepancy between declared dependencies and locked versions can cause build issues. If these updates are intentional, MODULE.bazel should be updated accordingly.

@renovate-bot
renovate-bot force-pushed the renovate/protobuf-monorepo branch from 692d74f to bd02f2a Compare March 25, 2026 09:19
@renovate-bot renovate-bot changed the title Update dependency protobuf to v34.1 chore(deps): update dependency protobuf to v34.1 Apr 16, 2026
@renovate-bot
renovate-bot force-pushed the renovate/protobuf-monorepo branch from bd02f2a to 8bceecb Compare April 16, 2026 04:27
@renovate-bot
renovate-bot force-pushed the renovate/protobuf-monorepo branch from 8bceecb to e3f657d Compare May 5, 2026 09:21
@renovate-bot
renovate-bot force-pushed the renovate/protobuf-monorepo branch from e3f657d to 4271514 Compare May 18, 2026 10:31
@renovate-bot renovate-bot changed the title chore(deps): update dependency protobuf to v34.1 Update dependency protobuf to v34.1 May 19, 2026
@LeFrosch LeFrosch mentioned this pull request May 21, 2026
1 task
@LeFrosch LeFrosch closed this May 21, 2026
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in Bazel IntelliJ Plugin May 21, 2026
@github-actions github-actions Bot removed the awaiting-review Awaiting review from Bazel team on PRs label May 21, 2026
@renovate-bot
renovate-bot deleted the renovate/protobuf-monorepo branch May 21, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product: CLion CLion plugin

Projects

Development

Successfully merging this pull request may close these issues.

3 participants