Update dependency protobuf to v34.1 - #8260
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the protobuf dependency to version 34.1. The changes in MODULE.bazel and the test project's MODULE.bazel are straightforward. However, the MODULE.bazel.lock file contains updates for other direct dependencies like the clion SDK and PythonCore plugins, which are not reflected in the MODULE.bazel diff for this PR. This inconsistency between the module definition and the lock file is a critical issue that could lead to unpredictable builds. The lock file must accurately reflect the intended dependencies defined in MODULE.bazel.
| "sha256": "4e1a694e99709e6f698aab31c4f9d0531dd05bfa763644e5ee8d163447fe2505", | ||
| "product": "clion", | ||
| "version": "261.22158.47-EAP-SNAPSHOT" | ||
| "version": "261.22158.190-EAP-SNAPSHOT" |
There was a problem hiding this comment.
The lock file is being updated for the clion SDK, but there is no corresponding change in MODULE.bazel within this pull request's diffs. This creates an inconsistency between the module definition and the lock file, which can lead to unpredictable builds. If this update is intentional, the change should also be present in MODULE.bazel.
| "sha256": "2d537031f4e5e2db5c9ccfa7703781518a829b293c0133a8690f6700092dd9f2", | ||
| "url": "https://plugins.jetbrains.com/maven/com/jetbrains/plugins/PythonCore/253.32098.37/PythonCore-253.32098.37.zip" | ||
| } | ||
| }, | ||
| "python_2026_1": { | ||
| "repoRuleId": "@@bazel_tools//tools/build_defs/repo:http.bzl%http_archive", | ||
| "attributes": { | ||
| "build_file": "@@//intellij_platform_sdk:BUILD.python", | ||
| "sha256": "5feec57a08bddd5aa7fdc72af5b977b850de980c25f6f6e4d6b59a3e0c18edf5", | ||
| "url": "https://plugins.jetbrains.com/maven/com/jetbrains/plugins/PythonCore/261.22158.46/PythonCore-261.22158.46.zip" | ||
| "sha256": "7443dfbb718efcf00d7bc790e58af2c8d9fdc5a911ce44c80764a38915226f62", | ||
| "url": "https://plugins.jetbrains.com/maven/com/jetbrains/plugins/PythonCore/261.22158.182/PythonCore-261.22158.182.zip" |
There was a problem hiding this comment.
The PythonCore plugin versions are being updated in the lock file without a corresponding change in MODULE.bazel in this PR's diffs. This discrepancy between declared dependencies and locked versions can cause build issues. If these updates are intentional, MODULE.bazel should be updated accordingly.
692d74f to
bd02f2a
Compare
bd02f2a to
8bceecb
Compare
8bceecb to
e3f657d
Compare
e3f657d to
4271514
Compare
This PR contains the following updates:
34.0.bcr.1→34.1Release Notes
protocolbuffers/protobuf (protobuf)
v34.1: Protocol Buffers v34.1Announcements
Bazel
protocoptflag out of theccdir, since it is not a c++-specific flag. (3db9fd1)763c5da)C++
5583485)523a6a4)763c5da)Java
ab3d7f0)Python
763c5da)Other
mkdircommand to followINTEGRITY_FILElocation. (e700d7d)f5ccaf3)Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.