Bazel CI is NPE-ing in AttributeContainer

[kchodorow]

I haven't verified, but I'm guessing this was caused by 178a3df. See, e.g., http://ci.bazel.io/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=linux-x86_64/524/console.

ERROR: �[0m/home/ci/workspace/Bazel/JAVA_VERSION/1.8/PLATFORM_NAME/linux-x86_64/WORKSPACE:39:1: /home/ci/workspace/Bazel/JAVA_VERSION/1.8/PLATFORM_NAME/linux-x86_64/WORKSPACE:39:1: [{"api_level": 23, "build_tools_version": "24.0.0-preview", "name": "androidsdk", "path": "/home/ci/android/android-sdk-linux"}, android_sdk_repository(name = "androidsdk", path = "/home...", <2 more arguments>), <Environment[workspace /home/ci/workspace/Bazel/JAVA_VERSION/1.8/PLATFORM_NAME/linux-x86_64/WORKSPACE]>] (java.lang.NullPointerException)
while calling com.google.devtools.build.lib.packages.AttributeContainer.setAttributeValue(AttributeContainer.java:103)
com.google.devtools.build.lib.packages.Rule.setAttributeValue(Rule.java:105)
com.google.devtools.build.lib.packages.RuleClass.setRuleAttributeValue(RuleClass.java:1679)
com.google.devtools.build.lib.packages.RuleClass.populateDefinedRuleAttributeValues(RuleClass.java:1428)
com.google.devtools.build.lib.packages.RuleClass.populateRuleAttributeValues(RuleClass.java:1371)
com.google.devtools.build.lib.packages.RuleClass.createRule(RuleClass.java:1345)
com.google.devtools.build.lib.packages.RuleFactory.createRule(RuleFactory.java:130)
com.google.devtools.build.lib.packages.ExternalPackageBuilder.addBindRule(ExternalPackageBuilder.java:92)
com.google.devtools.build.lib.packages.ExternalPackageBuilder.createAndAddRepositoryRule(ExternalPackageBuilder.java:61)
com.google.devtools.build.lib.packages.WorkspaceFactory$3.invoke(WorkspaceFactory.java:375)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
java.lang.reflect.Method.invoke(Method.java:498)
com.google.devtools.build.lib.syntax.BuiltinFunction.call(BuiltinFunction.java:157)
com.google.devtools.build.lib.syntax.BaseFunction.call(BaseFunction.java:443)
com.google.devtools.build.lib.syntax.FuncallExpression.invokeGlobalFunction(FuncallExpression.java:695)
com.google.devtools.build.lib.syntax.FuncallExpression.doEval(FuncallExpression.java:666)
com.google.devtools.build.lib.syntax.Expression.eval(Expression.java:48)
com.google.devtools.build.lib.syntax.ExpressionStatement.doExec(ExpressionStatement.java:46)
com.google.devtools.build.lib.syntax.Statement.exec(Statement.java:37)
com.google.devtools.build.lib.syntax.BuildFileAST.exec(BuildFileAST.java:152)
com.google.devtools.build.lib.packages.WorkspaceFactory.execute(WorkspaceFactory.java:204)
com.google.devtools.build.lib.packages.WorkspaceFactory.execute(WorkspaceFactory.java:174)
com.google.devtools.build.lib.skyframe.WorkspaceFileFunction.compute(WorkspaceFileFunction.java:113)
com.google.devtools.build.skyframe.ParallelEvaluator$Evaluate.run(ParallelEvaluator.java:954)
com.google.devtools.build.lib.concurrent.AbstractQueueVisitor$WrappedRunnable.run(AbstractQueueVisitor.java:515)
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
java.lang.Thread.run(Thread.java:745)
 with args android_sdk_repository(**kwargs)
Java parameter types: [interface java.util.Map, class com.google.devtools.build.lib.syntax.FuncallExpression, class com.google.devtools.build.lib.syntax.Environment]
Skylark type checks: null.

[janakdr]

I don't have any problem compiling this from head on my workstation, either
from head or at the problematic commit. Are there more specific repro
instructions?

On Wed, May 4, 2016 at 4:46 PM, Kristina notifications@github.com wrote:

Assigned #1234 #1234 to
@janakdr https://github.com/janakdr.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1234 (comment)

[damienmg]

You need to activate android tooling.

Everything that breaks the Bazel job should be either fixed or rolled-back in the next hours because it prevents to detect any other failures.

[damienmg]

Culprit confirmed by git bisect.

Repro:

diff --git a/WORKSPACE b/WORKSPACE
index dfa7ca5..0d38304 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -31,8 +31,8 @@ docker_repository()

 # In order to run the Android integration tests, run
 # scripts/workspace_user.sh and uncomment the next two lines.
-# load("/WORKSPACE.user", "android_repositories")
-# android_repositories()
+load("/WORKSPACE.user", "android_repositories")
+android_repositories()

 # This allows rules written in skylark to locate apple build tools.
 bind(name = "xcrunwrapper", actual = "@bazel_tools//tools/objc:xcrunwrapper")

And run ./scripts/workspace_user.sh

[damienmg]

The change got rollback. It has hidden another failure...

[janakdr]

This still doesn't repro for me on my Linux box with my rolled-back change
patched in and the changes to the WORKSPACE file that you gave. Any
additional pointers?

On Fri, May 6, 2016 at 5:56 AM, Damien Martin-Guillerez <
notifications@github.com> wrote:

The change got rollback. It has hidden another failure...

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1234 (comment)

[janakdr]

With Kristina's help, I'm able to get a repro by actually having the
android SDK installed. Digging ...

On Tue, May 10, 2016 at 1:24 PM, Janak Ramakrishnan janakr@google.com
wrote:

This still doesn't repro for me on my Linux box with my rolled-back change
patched in and the changes to the WORKSPACE file that you gave. Any
additional pointers?

On Fri, May 6, 2016 at 5:56 AM, Damien Martin-Guillerez <
notifications@github.com> wrote:

The change got rollback. It has hidden another failure...

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1234 (comment)