fix: correctly invalidate treeartifacts

[thesayyn]

No description provided.

[aspect-workflows]

Test (Bazel 7.x) (Test)

⚠️ Buildkite build #241 failed.

Failed tests (1)

//tar/tests:test23_file_level_cross_treeartifact_not_pruned [k8-fastbuild] 🔗

💡 To reproduce the test failures, run

bazel test //tar/tests:test23_file_level_cross_treeartifact_not_pruned

---

Test (Bazel 8.x) (Test)

⚠️ Buildkite build #241 failed.

Failed tests (1)

//tar/tests:test23_file_level_cross_treeartifact_not_pruned [k8-fastbuild] 🔗

💡 To reproduce the test failures, run

bazel test //tar/tests:test23_file_level_cross_treeartifact_not_pruned

---

Test (Bazel 9.x) (Test)

⚠️ Buildkite build #241 failed.

Failed tests (1)

//tar/tests:test23_file_level_cross_treeartifact_not_pruned [k8-fastbuild] 🔗

💡 To reproduce the test failures, run

bazel test //tar/tests:test23_file_level_cross_treeartifact_not_pruned

---

Test (Bazel 7.x) (Test)

e2e/smoke

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.

---

Test (Bazel 8.x) (Test)

e2e/smoke

All tests were cache hits

1 test (100.0%) was fully cached saving 25ms.

---

Test (Bazel 9.x) (Test)

e2e/smoke

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.

---

Test (WORKSPACE) (Test)

e2e/smoke

1 test target passed

Targets

//:smoke_test [k8-fastbuild]37ms

---

Test (Bazel 7.x) (Test)

examples

All tests were cache hits

3 tests (100.0%) were fully cached saving 135ms.

---

Test (Bazel 8.x) (Test)

examples

All tests were cache hits

3 tests (100.0%) were fully cached saving 179ms.

[chatgpt-codex-connector]

💡 Codex Review

tar.bzl/tar/private/tar.bzl

Line 509 in a589814

return _expand(symlink.target_file, expander, symlink.path)

Normalize root_symlink rlocation paths before expansion

Root runfile symlinks are expanded with symlink.path verbatim, unlike regular runfile symlinks/empty filenames which strip the ../ external-repo prefix. When a root symlink path is ../<repo>/... (the same pattern already handled elsewhere in this function), this produces mtree entries containing .. segments under the runfiles tree and can place files at incorrect archive paths. Normalizing root symlink paths the same way as s.default_runfiles.symlinks avoids this mismatch.

---

tar.bzl/tar/private/tar.bzl

Line 654 in a589814

awk_path = ":".join(awk_dirs.keys())

Use platform-specific separator when building AWKPATH

The wrapper now hardcodes AWKPATH entries joined with :. On Windows, include directories commonly contain drive-letter prefixes (for example C:/...), so colon-joining corrupts the search path and causes @include resolution in mtree_mutate to fail for custom scripts/preserve-symlinks mode. This should use an OS-appropriate separator (or avoid manual joining) to keep includes working cross-platform.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".