feat: implement less/greater operators for string for env marker evaluation - #2827
Merged
Conversation
groodt
approved these changes
Apr 26, 2025
groodt
left a comment
groodt
left a comment
Contributor
There was a problem hiding this comment.
LGTM
The implementation in packaging is here for reference https://github.com/pypa/packaging/blob/main/src/packaging/markers.py
aignas
approved these changes
Apr 27, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 27, 2025
aignas
reviewed
Apr 27, 2025
…into pep508.str.ltegte
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 29, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 29, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, if two strings are compared, it results in an error.
Per spec, strings are suppose to "use the python behavior". Starlark is going
to use Java semantics underneath, but it should behave close enough for the (almost
exclusively) ASCII input that will be used.
Work towards #2826