docs: document some of our project styles/conventions - #2816
Merged
Conversation
dougthor42
approved these changes
Apr 23, 2025
dougthor42
left a comment
dougthor42
left a comment
Collaborator
There was a problem hiding this comment.
Couple questions but nothing blocking. LGTM.
aignas
reviewed
Apr 23, 2025
aignas
reviewed
Apr 24, 2025
aignas
approved these changes
Apr 24, 2025
aignas
enabled auto-merge
April 29, 2025 13:57
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 29, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 29, 2025
Spurred by the discussion to converge on using `.` to separate generated targets, I wrote down some of the conventions we've adopted. --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spurred by the discussion to converge on using
.to separate generated targets, Iwrote down some of the conventions we've adopted.