:edn :coerce option must have explicit value#189
Merged
Conversation
Coercing to implicit `true` for `--foo` and implicit `false` for `--no-foo` for `:edn` coercions was confusing for CLI usability. `--foo` on an `:edn` option now generates a missing value error `--no-foo` on an `:edn` option now generates a cannot negate error. Also added a brief section explaining `:edn` coercion to README. It wasn't previously covered. Closes #174
Contributor
|
Thanks! |
lread
added a commit
that referenced
this pull request
Jun 26, 2026
* main: `:edn` `:coerce` option must have explicit value (#189)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coercing to implicit
truefor--fooand implicitfalsefor--no-foofor:edncoercions was confusing for CLI usability.--fooon an:ednoption now generates a missing value error--no-fooon an:ednoption now generates a cannot negate error.Also added a brief section explaining
:edncoercion to README. It wasn't previously covered.Closes #174