Skip to content

Validate SUBACK/UNSUBACK reason code count - #432

Merged
sfod merged 3 commits into
mainfrom
handle-excess-reason-codes
Aug 6, 2026
Merged

Validate SUBACK/UNSUBACK reason code count#432
sfod merged 3 commits into
mainfrom
handle-excess-reason-codes

Conversation

@sfod

@sfod sfod commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This is a follow-up for #431

Validate SUBACK/UNSUBACK reason code count against the acknowledged request. When a mismatch detected, the client fails the offending operation and disconnects sending a DISCONNECT with a reason code.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter

codecov-commenter commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.66%. Comparing base (e35b9ca) to head (f4d459f).

Files with missing lines Patch % Lines
source/v5/mqtt5_client.c 95.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #432   +/-   ##
=======================================
  Coverage   84.65%   84.66%           
=======================================
  Files          26       26           
  Lines       11093    11109   +16     
=======================================
+ Hits         9391     9405   +14     
- Misses       1702     1704    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread source/v5/mqtt5_client.c
@sfod
sfod merged commit 97842b0 into main Aug 6, 2026
74 of 78 checks passed
@sfod
sfod deleted the handle-excess-reason-codes branch August 6, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants