Improve retry logic during stream scaling by succeeding records that lande… - #576
Merged
Merged
Conversation
…d on the correct hash range of shard
nsnikita-aws
left a comment
nsnikita-aws
left a comment
There was a problem hiding this comment.
Except few nit comments looks good to me, thank you!
chenylee-aws
force-pushed
the
reduce_retry_storm
branch
from
August 19, 2024 05:20
d624f7c to
3e61369
Compare
chenylee-aws
force-pushed
the
reduce_retry_storm
branch
from
August 19, 2024 05:50
3e61369 to
1800da3
Compare
nsnikita-aws
approved these changes
Aug 21, 2024
furq-aws
approved these changes
Aug 21, 2024
chenylee-aws
changed the title
chenylee-aws
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…within the hash range of the actual put-to shard
Description of changes:
During stream scaling with KPL aggregation enabled, KPL users can experience a high number of throttling events from Kinesis and an increase in stream ingestion throughput due to excessive retries. This issue occurs when KPL fails and retries records whenever a record doesn't land on the predicted shard. This change aims to ensure that KPL can intelligently decide whether to retry a record based on the hash range of the actual shard.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.