test: exercise security reviewer workflow [DO NOT MERGE] - #3300
Draft
WesleyRosenblum wants to merge 4 commits into
Draft
test: exercise security reviewer workflow [DO NOT MERGE]#3300WesleyRosenblum wants to merge 4 commits into
WesleyRosenblum wants to merge 4 commits into
Conversation
Intentionally weaken several independent validation and protocol safety checks to exercise the security reviewer workflow. This commit is test-only and must not be merged.
Add more intentionally unsafe validation and protocol changes to exercise the newly enabled security review workflow. This commit is test-only and must not be merged.
Contributor
🔒 Security review
Report access is restricted to maintainers. |
Restore every validation and protocol-safety check deliberately weakened for the security reviewer workflow test. The affected source files now match main exactly.
Document why decoder bounds checks and authenticated-decryption error propagation must remain in place.
boquan-fang
reviewed
Sep 3, 2026
Contributor
There was a problem hiding this comment.
The behavior of the next couple runs of tests are updating the existing comment instead of submitting another comment. Personally, I find submitting another comment might be more useful, since it tracks the flow of commits.
#3300 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
None.
Description of changes:
DO NOT MERGE. SECURITY REVIEWER WORKFLOW TEST.
This draft intentionally weakens multiple security and protocol-safety checks in production code to exercise an automated security reviewer workflow. These changes are not intended for release or deployment.
Call-outs:
The planted findings are intentionally not enumerated here so the reviewer can be evaluated independently. Close this draft without merging after the workflow test is complete.
Testing:
cargo fmt --all -- --checkcargo build -p s2n-codec@0.88.0 -p s2n-quic-transport@0.88.0 -p s2n-quic-dc@0.88.0Both commands completed successfully.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.