Skip to content

ci: add audit workflow - #2

Merged
camshaft merged 6 commits into
masterfrom
ci-audit-workflow
Jul 2, 2020
Merged

ci: add audit workflow#2
camshaft merged 6 commits into
masterfrom
ci-audit-workflow

Conversation

@camshaft

Copy link
Copy Markdown
Contributor

Adds cargo audit workflow

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

rday
rday previously approved these changes Jul 2, 2020
Comment thread .github/workflows/main.yml Outdated

steps:
- uses: hecrj/setup-rust-action@v1
- uses: actions/checkout@master

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better point in time than master here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag actions/checkout@v2 mostly tracks master and is worth considering

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's fair

dougch
dougch previously approved these changes Jul 2, 2020

@dougch dougch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment

Comment thread .github/workflows/main.yml Outdated

steps:
- uses: hecrj/setup-rust-action@v1
- uses: actions/checkout@master

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag actions/checkout@v2 mostly tracks master and is worth considering

@camshaft
camshaft dismissed stale reviews from dougch and rday via 7c28fdb July 2, 2020 18:42

@dougch dougch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dougch
dougch requested a review from rday July 2, 2020 18:47
@camshaft
camshaft merged commit 3d1b3c9 into master Jul 2, 2020
@camshaft
camshaft deleted the ci-audit-workflow branch July 2, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants