Fix -Wmissing-variable-declarations warnings on PG 18 / PG 19 builds#312
Open
devrimgunduz wants to merge 1 commit into
Open
Fix -Wmissing-variable-declarations warnings on PG 18 / PG 19 builds#312devrimgunduz wants to merge 1 commit into
devrimgunduz wants to merge 1 commit into
Conversation
PG 18 introduced -Wmissing-variable-declarations to PostgreSQL's
standard build flags (src/Makefile.global.in / CFLAGS_SL / bitcode
CFLAGS), which clang now applies to extension builds too. The flag
flags any file-scope, non-static variable definition that has no
prior extern declaration in scope. pg_tle defines four such globals:
* src/passcheck.c : pass_types
* src/tleextension.c : cb_registered, tleart, tleext
All four are only used within the translation unit that defines
them (grep confirms no other .c file references them and no header
declares them extern), so they were always meant to be file-private.
They were simply never marked 'static'.
Fix:
Mark all four variables 'static'.
Hacked by Claude, tested by me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PG 18 introduced -Wmissing-variable-declarations to PostgreSQL's
standard build flags (src/Makefile.global.in / CFLAGS_SL / bitcode
CFLAGS), which clang now applies to extension builds too. The flag
flags any file-scope, non-static variable definition that has no
prior extern declaration in scope. pg_tle defines four such globals:
All four are only used within the translation unit that defines
them (grep confirms no other .c file references them and no header
declares them extern), so they were always meant to be file-private.
They were simply never marked 'static'.
Fix:
Mark all four variables 'static'.
Hacked by Claude, tested by me.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.