Add default protected constructor for HttpClientBuilder - #90
Merged
Conversation
…ilder with null recorder from being created (aws#89)
luluzhao
approved these changes
Aug 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#89
Description of changes:
Added protected constructor. The parent Apache HttpClientBuilder implements a protected constructor as well. There was a bug that allowed customers to instantiate our HttpClientBuilder through an implicitly created public constructor. This is a problem because then the recorder instance will be null.
Testing:
Wrote a unit test to ensure that the constructor has the protected modifier.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.