Revert subsegment synchronization changes - #350
Merged
Conversation
added 8 commits
August 12, 2022 14:17
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
============================================
- Coverage 58.82% 58.24% -0.59%
- Complexity 1207 1210 +3
============================================
Files 131 131
Lines 5076 4948 -128
Branches 594 590 -4
============================================
- Hits 2986 2882 -104
+ Misses 1817 1791 -26
- Partials 273 275 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#303
Description of changes:
This PR reverts the changes to the segment/subsegment synchronization logic made in the following previous PRs:
#250
#278
#279
#306
This should revert the SDK's synchronization behavior to a known good state in v2.8.0 and resolve the deadlocking issues. We maintained the public methods introduced by these PRs for backwards compatibility.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.